Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update usage of .local with .minikube in k8s docs #1551

Merged
merged 1 commit into from
May 19, 2017
Merged

Update usage of .local with .minikube in k8s docs #1551

merged 1 commit into from
May 19, 2017

Conversation

errm
Copy link
Contributor

@errm errm commented May 4, 2017 •
edited
Loading

Description

fixes #1521

@errm errm requested review from timoreimann and dtomcej May 4, 2017 13:08
timoreimann
timoreimann approved these changes May 4, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ldez ldez added this to the 1.4 milestone May 4, 2017
@errm errm force-pushed the update-minikube-example-dns branch from 4db9cd2 to a428c32 Compare May 4, 2017 15:30
@errm errm closed this May 16, 2017
@errm errm reopened this May 16, 2017
@errm errm force-pushed the update-minikube-example-dns branch from a428c32 to 88e9138 Compare May 16, 2017 12:23
emilevauge
emilevauge approved these changes May 19, 2017
View reviewed changes
Copy link
Member

@emilevauge emilevauge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @errm
LGTM

@ldez ldez force-pushed the update-minikube-example-dns branch from 88e9138 to 4399a8d Compare May 19, 2017 14:38
@ldez ldez merged commit c7281df into traefik:master May 19, 2017
@ldez ldez mentioned this pull request Jul 22, 2017
Closed
@errm errm deleted the update-minikube-example-dns branch September 28, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilevauge emilevauge emilevauge approved these changes

@timoreimann timoreimann timoreimann approved these changes

@dtomcej dtomcej Awaiting requested review from dtomcej

Assignees
No one assigned
Labels
area/documentation area/provider/k8s/ingress
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

Minikube example: traefik-ui.local → traefik-ui.minikube?
4 participants
@errm @timoreimann @emilevauge @ldez