Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double compression. #1863

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Double compression. #1863

merged 1 commit into from
Jul 18, 2017

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jul 13, 2017 •
edited
Loading

Description

Fix double compression.

Fixes #1851

@ldez ldez added this to the 1.3 milestone Jul 13, 2017
@ldez ldez changed the base branch from master to v1.3 July 13, 2017 17:50
@ldez ldez force-pushed the fix/double-compression branch 2 times, most recently from 2a645fd to 55860d3 Compare July 14, 2017 06:37
@ldez ldez force-pushed the fix/double-compression branch from 55860d3 to dc0e6a7 Compare July 14, 2017 07:08
@ldez ldez changed the title fix: double compression. Double compression. Jul 14, 2017
nmengin
nmengin approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

timoreimann
timoreimann approved these changes Jul 18, 2017
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

juliens
juliens approved these changes Jul 18, 2017
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit 36ee696 into traefik:v1.3 Jul 18, 2017
@kachkaev
Copy link
Contributor

Thanks for the fix @ldez! When about are you planning to cut a new release with this fix? Just curious.

@ldez ldez deleted the fix/double-compression branch July 23, 2017 19:07
@ldez
Copy link
Contributor Author

ldez commented Jul 23, 2017

@kachkaev this week 😉

@kachkaev
Copy link
Contributor

kachkaev commented Jul 27, 2017 •
edited
Loading

Hi guys, any update on the release by a chance? Just installed wordpress and am seeing this 😆
(https is on and the lock is green)

wp-double

@chexxor
Copy link

chexxor commented Jul 27, 2017

@kachkaev I upgraded to the latest release and found the double-compression issue is fixed. 👍
Release name is "v1.3.4", using this image: https://hub.docker.com/r/containous/traefik/
Thanks @ldez!

@kachkaev
Copy link
Contributor

It works, thanks @chexxor !!!

@ldez ldez mentioned this pull request Jul 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@timoreimann timoreimann timoreimann approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
6 participants
@ldez @kachkaev @chexxor @juliens @timoreimann @nmengin