Redirect to another entryPoint per frontend #2133

SantoDE · 2017-09-18T15:01:33Z

Description

This PR makes it possible, to enable a redirect to another entrypoint per frontend. Current Supported Backends are:

Docker
Kubernetes
Rancher

The only thing you need to do is, set e.g. traefik.frontend.redirect=https.

If this redirect is enabled, it's shown on the dashboard as well.

emilevauge

Hey @SantoDE !
Hum 🤔, I think it would be better to stick with the current behavior and not redefine another way to redirect.
How about using a label traefik.frontend.redirect=https to achieve this ? This would allow to reuse some code ;)
WDYT @containous/traefik ?

SantoDE · 2017-09-19T16:34:01Z

Hey @emilevauge ,
could you check again please? :)

dtomcej · 2017-09-19T18:44:04Z

@SantoDE Do you think that you could leverage the Headers middleware to accomplish this?

By setting the SSLRedirect = true for that frontend will invoke the middleware, and will provide redirection. That would also allow different hosts, 301 vs 302 redirects etc.

I am currently implementing the full gamut of options in 2030. Unfortunately, I have been delayed due to school.

PR 2146 is attempting to do part of this.

@containous/traefik Thoughts?

SantoDE · 2017-09-19T18:53:57Z

@dtomcej we would then be doing to different kind of rewrites for the "same" case. The entryPoint https redirect works the same way by utilizing the rewrite middleware. Im personally not bound to either way, but we should use the same in both cases

dtomcej · 2017-09-19T19:33:57Z

@SantoDE I don't disagree. Unfortunately we have a bunch of different places to accomplish the same thing. I don't want to duplicate or introduce duplicate code. All the providers have access to invoke the headers middleware, and so might be a clean way to invoke the same functions.

Although, we should decide on if that is the way we want to proceed.

dtomcej · 2017-09-19T19:36:06Z

An example would be that you introduce an httpsredirect property to the frontend struct. There is already a Header property there, that has a SSLRediret property inside. That would allow you to use already-existing code to accomplish the same function.

SantoDE · 2017-09-19T19:39:01Z

Would you then move the entryPoint redirect behavior as well? I personally don't like to utilize different rewrites from entryPoint to frontends.

@emilevauge halp! :)

kachkaev · 2017-09-26T23:42:23Z

Hi @SantoDE @emilevauge! Given that there are still a couple of other features pending for 1.4, do you think this one could also somehow fit the same release? Configrinfg the behavior of https redirects sounds like a great option for many mixed-use environments (especially those serving legacy pre-letsencrypt stuff). Agree with @SantoDE that the PR will close #1456 (which has relatively high number of 👍).

BTW there seems to exist an intersection with #2146 if I’m not wrong.

SantoDE · 2017-09-30T20:59:27Z

Hey @emilevauge , @dtomcej and more.

I updated my code like you suggested. I also changed the web ui once again.

Looking forward to your feedback :)

@kachkaev yeah there is some intersection but it's not too bad :) This PR will be included in 1.5 I guess.

emilevauge

Design LGTM
Thanks @SantoDE 👏
Could update you PR description accordingly ?

tiangolo · 2017-11-18T12:55:38Z

Merged! Awesome news! 🎉 Thanks @SantoDE for the work!

Traefik team: when do you think this feature would be available in the public Docker images? Which tag would it be in? 1.4.4 ?

ldez · 2017-11-18T13:21:05Z

@tiangolo We put only bug fix in the branch 1.4 (https://github.com/containous/traefik#release-cycle)

As you see the milestone is 1.5.

tourshi · 2017-12-21T15:41:01Z

I've tried to make use of this https redirect in v1.5.0-rc3 but can't seem to get it to work. I've tried multiple scenarios, non of which result in http to https redirects.

        labels:
            - traefik.backend=host.com
            - traefik.frontend.rule=Host:host.com,www.host.com
            - traefik.docker.network=traefik
            - traefik.frontend.entryPoints=http
            - traefik.frontend.redirect=https
            - traefik.enable=true

Am I misunderstanding something here?

Thank you!

ldez · 2017-12-21T16:02:26Z

@tourshi Due to #2570:

        labels:
            - traefik.backend=host.com
            - traefik.frontend.rule=Host:host.com,www.host.com
            - traefik.docker.network=traefik
            - traefik.frontend.entryPoints=http
            - traefik.frontend.redirect.entryPoint=https
            - traefik.enable=true

http://v1-5.archive.docs.traefik.io/configuration/backends/docker/#on-service

tourshi · 2017-12-21T17:10:05Z

Thank you @ldez I gave the regex/replacement solution a try, but it seems to break my traefik setup. These are the labels I used:
- traefik.frontend.redirect.regex="^http:\/\/host.com\/(.*)" - traefik.frontend.redirect.replacement="https:\/\/host.com\/$1"

In any case, I want to thank you for your help! I did come across this label:
traefik.frontend.headers.SSLRedirect=true
which solves my basic need of redirecting all http to https

Thank you!

h-bragg · 2018-01-22T10:37:15Z

I have a local setup that by default redirects http to https. However I would like a single container to work on http only (for legacy reasons [as always]). I couldn't figure out which combinations of labels would work to enable that.

in effect I would like:

http->http https->http for a single host
http->https https->https for everything else

The setup is plain old docker running locally with the following default configuration:

[entryPoints]
  [entryPoints.http]
  address = ":80"
    [entryPoints.http.redirect]
    entryPoint = "https"
  [entryPoints.https]
  address = ":443"
    [entryPoints.https.tls]

I have tried:

    labels:
      traefik.http.frontend.entryPoints: http
      traefik.http.frontend.redirect: http
      traefik.https.frontend.entryPoints: https
      traefik.https.frontend.redirect: http

    labels:
      traefik.frontend.headers.SSLRedirect: 'false'

    labels:
      traefik.frontend.entryPoints: http
      traefik.frontend.redirect.entryPoint: http

and various combinations of the above. Am I missing something obvious?

Version:      v1.5.0-rc5
Codename:     cancoillotte
Go version:   go1.9.2
Built:        2018-01-15_03:59:03PM
OS/Arch:      linux/amd64

DMW007 · 2018-01-28T18:25:00Z

@h-bragg The SSLRedirect header works but you've to pass it like any other label with equal sign and not colon. In addition to this, you need both http and https entrypoints. Without http we get an 404.

Working example for redirect http to https:

   labels: 
      - "traefik.port=80"
      - "traefik.frontend.rule=Host:MySecureDomain"
      - "traefik.frontend.headers.SSLRedirect=true"
      - "traefik.frontend.entryPoints=http,https"

For your other container, simply drop the redirect-header and https entrypoint like this:

    labels:
      - "traefik.port=80"
      - "traefik.frontend.rule=Host:MyInsecureDomain"
      - "traefik.frontend.entryPoints=http"

I tested this using latest stable docker release (traefik:1.5-alpine at the time of writing). Please keep in mind, that browser tend to cache redirects. So I used wget on the command line, there you can see the plain redirect without any caching issues.

h-bragg · 2018-01-29T12:46:45Z

@DMW007 thanks, I have it working like this for now.

Was looking for it to be ssl by default with http as the exception (each thing connecting to it might be done by a different person, so the least amount of configuration required is better).

mhumeSF · 2018-02-21T23:12:21Z

Wanted to test this out locally. I'm in a use case where ssl termination is happening at a load balancer before hitting traefik, but would still like traefik to handle the redirect of http to https. Is there a way to disable ssl, or using a different port to handle http requests?

±  curl -I -H Host:web.localhost https://127.0.0.1:443
curl: (35) LibreSSL SSL_connect: SSL_ERROR_SYSCALL in connection to 127.0.0.1:443

docker-compose.yml

version: '2'

services:
  web:
    image: nginx:alpine
    ports:
      - "80"
    labels:
      - "traefik.enable=true"
      - "traefik.frontend.rule=Host:web.localhost"
      - "traefik.port=80"
      - "traefik.frontend.headers.SSLRedirect=true"
      - "traefik.frontend.entryPoints=http,https"

  proxy:
    image: traefik
    command: --api --docker --docker.domain=docker.localhost --logLevel=DEBUG
    ports:
      - "80:80"
      - "443:443"
      - "8080:8080"
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
      - /dev/null:/traefik.toml

ldez · 2018-02-22T00:20:00Z

Thanks for your interest in Traefik 😃

A pull request is not the place for question. Please come discuss this in :

the Traefik community Slack
Stack Overflow using the "traefik" tag

SantoDE requested review from a team as code owners September 18, 2017 15:01

traefiker added area/provider/docker area/provider/k8s/ingress area/provider/rancher area/webui size/M status/0-needs-triage labels Sep 18, 2017

ldez added this to the 1.5 milestone Sep 18, 2017

ldez added status/1-needs-design-review and removed status/0-needs-triage labels Sep 18, 2017

SantoDE force-pushed the feature/redirect_per_frontend branch from 473a464 to 4e3bee4 Compare September 18, 2017 19:03

emilevauge reviewed Sep 19, 2017

View reviewed changes

SantoDE force-pushed the feature/redirect_per_frontend branch 5 times, most recently from 6533724 to b5f435b Compare September 30, 2017 20:56

SantoDE force-pushed the feature/redirect_per_frontend branch from b5f435b to d37fe4d Compare September 30, 2017 21:05

emilevauge reviewed Oct 6, 2017

View reviewed changes

emilevauge added the status/2-needs-review label Oct 6, 2017

ldez removed the status/2-needs-review label Nov 17, 2017

traefiker added the status/4-merge-in-progress label Nov 17, 2017

Manuel Laufenberg and others added 2 commits November 17, 2017 16:46

rebase and apply feedback

f966d91

refactor: code review.

d89be5a

traefiker force-pushed the feature/redirect_per_frontend branch from 70e3542 to d89be5a Compare November 17, 2017 16:46

traefiker added bot/need-human-merge and removed status/4-merge-in-progress labels Nov 17, 2017

traefiker approved these changes Nov 18, 2017

View reviewed changes

ldez removed the bot/need-human-merge label Nov 18, 2017

traefiker merged commit 5d6384e into traefik:master Nov 18, 2017

traefiker removed the status/3-needs-merge label Nov 18, 2017

gavinbunney mentioned this pull request Dec 7, 2017

Individual frontend redirect throwing nil pointer #2540

Closed

ldez mentioned this pull request Dec 7, 2017

Fix frontend redirect #2544

Merged

1 task

ldez mentioned this pull request Dec 14, 2017

Support regex redirect by frontend #2570

Merged

2 tasks

kazigk mentioned this pull request Dec 21, 2017

Redirect to another entrypoint only if it is enabled #2596

Closed

ldez changed the title ~~redirect to another entryPoint per frontend~~ Redirect to another entryPoint per frontend Jan 7, 2018

ldez mentioned this pull request Jan 27, 2018

Frontend-based Redirect Rules #987

Closed

DMW007 mentioned this pull request Jan 28, 2018

Redirect all requests on entrypoint, even without frontend #2109

Closed

traefik locked and limited conversation to collaborators Feb 22, 2018

SantoDE deleted the feature/redirect_per_frontend branch October 12, 2018 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redirect to another entryPoint per frontend #2133

Redirect to another entryPoint per frontend #2133

SantoDE commented Sep 18, 2017 •

edited by ldez

Loading

emilevauge left a comment

SantoDE commented Sep 19, 2017

dtomcej commented Sep 19, 2017

SantoDE commented Sep 19, 2017

dtomcej commented Sep 19, 2017 •

edited

Loading

dtomcej commented Sep 19, 2017

SantoDE commented Sep 19, 2017

kachkaev commented Sep 26, 2017

SantoDE commented Sep 30, 2017

emilevauge left a comment

tiangolo commented Nov 18, 2017

ldez commented Nov 18, 2017

tourshi commented Dec 21, 2017

ldez commented Dec 21, 2017 •

edited

Loading

tourshi commented Dec 21, 2017

h-bragg commented Jan 22, 2018 •

edited

Loading

DMW007 commented Jan 28, 2018 •

edited by ldez

Loading

h-bragg commented Jan 29, 2018

mhumeSF commented Feb 21, 2018 •

edited by ldez

Loading

ldez commented Feb 22, 2018

Redirect to another entryPoint per frontend #2133

Redirect to another entryPoint per frontend #2133

Conversation

SantoDE commented Sep 18, 2017 • edited by ldez Loading

Description

emilevauge left a comment

Choose a reason for hiding this comment

SantoDE commented Sep 19, 2017

dtomcej commented Sep 19, 2017

SantoDE commented Sep 19, 2017

dtomcej commented Sep 19, 2017 • edited Loading

dtomcej commented Sep 19, 2017

SantoDE commented Sep 19, 2017

kachkaev commented Sep 26, 2017

SantoDE commented Sep 30, 2017

emilevauge left a comment

Choose a reason for hiding this comment

tiangolo commented Nov 18, 2017

ldez commented Nov 18, 2017

tourshi commented Dec 21, 2017

ldez commented Dec 21, 2017 • edited Loading

tourshi commented Dec 21, 2017

h-bragg commented Jan 22, 2018 • edited Loading

DMW007 commented Jan 28, 2018 • edited by ldez Loading

h-bragg commented Jan 29, 2018

mhumeSF commented Feb 21, 2018 • edited by ldez Loading

ldez commented Feb 22, 2018

SantoDE commented Sep 18, 2017 •

edited by ldez

Loading

dtomcej commented Sep 19, 2017 •

edited

Loading

ldez commented Dec 21, 2017 •

edited

Loading

h-bragg commented Jan 22, 2018 •

edited

Loading

DMW007 commented Jan 28, 2018 •

edited by ldez

Loading

mhumeSF commented Feb 21, 2018 •

edited by ldez

Loading