Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Trust Forwarded Headers #2302

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Oct 23, 2017

Description

  • fix trust X headers
  • add X-Forwarded-Port
  • add X-Real-Ip

Fixes #1220, #293

@ldez ldez added bot/light-review decreases the number of required LGTM from 3 to 1. kind/bug/fix a bug fix status/2-needs-review labels Oct 23, 2017
@traefiker traefiker added this to the 1.4 milestone Oct 23, 2017
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- fix trust X headers
- add X-Forwarded-Port
- add X-Real-Ip
@traefiker traefiker merged commit 35ca40c into traefik:v1.4 Oct 23, 2017
@traefiker traefiker removed bot/light-review decreases the number of required LGTM from 3 to 1. status/3-needs-merge labels Oct 23, 2017
@ldez ldez deleted the fix/headerrewriter branch October 23, 2017 14:16
gulien pushed a commit to thecodingmachine/kickoff-docker-php that referenced this pull request Nov 20, 2017
* Bump Traefik to 1.4.3 to incorporate traefik/traefik#2302 (enables proper X-Forwarded-Port for PHP frameworks depending on X-Forwarded* during URL generation e.g. Symfony with setTrustedProxies enabled)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants