Fix custom headers replacement #2455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmatur
force-pushed
the
fix-custom-response-header
branch
2 times, most recently
from
d5bff1a to
ad5a5ce
Compare
mmatur
force-pushed
the
fix-custom-response-header
branch
2 times, most recently
from
b65476a to
4236e98
Compare
mmatur
force-pushed
the
fix-custom-response-header
branch
from
4236e98 to
8430be8
Compare
traefiker
force-pushed
the
fix-custom-response-header
branch
from
8430be8 to
ff23daf
Compare
|
Hi, how is this going? Any plans to release this functionality? |
|
@Xumeiquer the milestone of the PR define the related Træfik version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fix issue with custom headers. Before headers were not overridden but added.
Now if the custom header name is the same as one header name of the request or response, it will be replaced.
Add feature to delete header
X-Custom-Request-Header = ""headerX-Custom-Request-Headerwill be deletedMore
Fixes #1155, #2341