Add a note on how to add label to a docker compose file #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
added
bot/no-merge
kind/enhancement
|
Could you rebase on the 1.5 branch ? |
jmaitrehenry
force-pushed
the
update_docker_label_doc
branch
from
169a4c1 to
5c14b09
Compare
|
@ldez done |
vdemeester
previously requested changes
Dec 22, 2017
| @@ -145,6 +145,18 @@ To enable constraints see [backend-specific constraints section](/configuration/ | |||
|
|
|||
| ## Labels: overriding default behaviour | |||
|
|
|||
| !!! note | |||
| If you use a docker-compose file, labels should be defined in the `deploy` part of your service. | |||
There was a problem hiding this comment.
s/docker-compose file/composefile/
nmengin
requested changes
Dec 22, 2017
There was a problem hiding this comment.
Hello @jmaitrehenry
Many thanks for this PR which can be helpful for docker-compose beginners 😉
I have two little suggestions.
| @@ -145,6 +145,18 @@ To enable constraints see [backend-specific constraints section](/configuration/ | |||
|
|
|||
| ## Labels: overriding default behaviour | |||
|
|
|||
| !!! note | |||
| If you use a docker-compose file, labels should be defined in the `deploy` part of your service. | |||
There was a problem hiding this comment.
Can precise two points :
- This behavior is only enabled for docker-compose API 3+
- Add a ling to the docker-compose documentation : https://docs.docker.com/compose/compose-file/#labels-1
| ```yaml | ||
| version: "3" | ||
| services: | ||
| nginx: |
There was a problem hiding this comment.
Can you use another service name? Like whoami for example? 😉
There was a problem hiding this comment.
Oups sure, I always use nginx as service example, I didn't realize.
jmaitrehenry
force-pushed
the
update_docker_label_doc
branch
from
5c14b09 to
b2736af
Compare
traefiker
force-pushed
the
update_docker_label_doc
branch
from
b2736af to
c76902e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a note to the docker backend documentation page on how to add a label using a docker-compose file.
Motivation
I made the mistake too many time and I still forgot about it.
When reading the documentation, I can't find a notice/note about it.
More
Additional Notes