Simplify storing renewed acme certificate #2614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferhatelmas
force-pushed
the
acme-certificate-renew
branch
from
ed7f0bd to
9e8e122
Compare
nmengin
approved these changes
Dec 22, 2017
nmengin
added
kind/enhancement
ldez
changed the title
traefiker
force-pushed
the
acme-certificate-renew
branch
from
9e8e122 to
cddb521
Compare
Account argument was passed but it was actually accessed through store and there was no need to pass it so dropped that argument.
traefiker
force-pushed
the
acme-certificate-renew
branch
from
cddb521 to
85fe21e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Simplification in storing renewed certificate in acme certificate renewal.
Motivation
Not to mislead readers.
Additional Notes
Account argument was passed but it was actually accessed through store and there was no need to pass it so dropped that argument.