Don't panic if ResponseWriter does not implement CloseNotify #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliens
changed the title
nmengin
requested changes
Jan 4, 2018
middlewares/retry.go
Outdated
| GetBody() *bytes.Buffer | ||
| IsStreamingResponseStarted() bool | ||
| } | ||
|
|
||
| // retryResponseRecorder is an implementation of http.ResponseWriter that |
There was a problem hiding this comment.
Might be changed into retryResponseRecorderWithoutCloseNotify or moved above?
juliens
force-pushed
the
close-notify-retry
branch
from
f6009c4 to
833745a
Compare
traefiker
force-pushed
the
close-notify-retry
branch
from
37adb8f to
5e4ecbf
Compare
|
i still see this in 1.5.0 final if i disable http compression it is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix a panic in the retry middleware if the responseWriter does not implement CloseNotify. Happen with compress=true (Gzip does not implement CloseNotify yet)
Motivation
Fixes #2628
More
I think this is better that the next handler choose what to do if we don't implement CloseNotify instead of Panic or implement a wrong version of CloseNotify.