Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogenization of templates: Rancher #2662

Merged
merged 2 commits into from
Jan 10, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Jan 5, 2018

What does this PR do?

Simplify template and use typed function.

Motivation

Homogenization of the providers [part3]: try to have a shared template

More

  • Added/updated tests

@ldez ldez added kind/enhancement a new or improved feature. status/2-needs-review labels Jan 5, 2018
@ldez ldez added this to the 1.6 milestone Jan 5, 2018
@ldez ldez requested a review from a team as a code owner January 5, 2018 18:53
@ldez ldez force-pushed the refactor/rancher-template branch from 24239cf to c8ce6f3 Compare January 7, 2018 16:33
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez force-pushed the refactor/rancher-template branch from c8ce6f3 to 5637c4c Compare January 9, 2018 19:11
@ldez ldez removed the bot/no-merge label Jan 9, 2018
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker force-pushed the refactor/rancher-template branch from 5637c4c to 0ddf2cf Compare January 10, 2018 16:50
@traefiker traefiker merged commit 0d57e2a into traefik:master Jan 10, 2018
@ldez ldez deleted the refactor/rancher-template branch January 10, 2018 18:39
@ldez ldez mentioned this pull request Jan 30, 2018
8 tasks
@ldez ldez changed the title homogenization of templates: Rancher Homogenization of templates: Rancher Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants