Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate command from the main package #2951

Merged
merged 3 commits into from
Mar 1, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented Feb 28, 2018

What does this PR do?

Separate command from the main package

Motivation

Separation of concern 👼

@juliens juliens force-pushed the separate-command branch 2 times, most recently from 08635b3 to 4cbd5cc Compare February 28, 2018 15:55
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur added this to the 1.6 milestone Feb 28, 2018
@mmatur mmatur added the kind/enhancement a new or improved feature. label Feb 28, 2018
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 831a3e3 into traefik:master Mar 1, 2018
@juliens juliens deleted the separate-command branch April 18, 2018 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement a new or improved feature. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants