Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Delay by RefreshSecond in Eureka #2972

Merged
merged 2 commits into from
Mar 7, 2018
Merged

Replace Delay by RefreshSecond in Eureka #2972

merged 2 commits into from
Mar 7, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 6, 2018

What does this PR do?

add a new option RefreshSecond, it replace Delay.

Motivation

Have the same option's name between provider.

More

  • Added/updated tests
  • Added/updated documentation

@ldez ldez added this to the 1.6 milestone Mar 6, 2018
@ldez ldez force-pushed the refactor/eureka branch 2 times, most recently from ccba93c to 3d3d4ba Compare March 6, 2018 15:12
juliens
juliens approved these changes Mar 6, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Mar 7, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eureka! 😉
LGTM

mmatur
mmatur approved these changes Mar 7, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 3a2b421 into traefik:master Mar 7, 2018
@ldez ldez deleted the refactor/eureka branch March 7, 2018 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/eureka kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@ldez @juliens @mmatur @nmengin @traefiker