Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lower-case passHostHeader key support. #3015

Merged
merged 1 commit into from
Mar 15, 2018

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Mar 14, 2018

What does this PR do?

passHostHeader is the only key in camel-case.
storeconfig command store keys in lower-case.

Add support for passhostheader, fallback on passHostHeader is needed.

Motivation

Fixes #2103

More

  • Added/updated documentation

Additional Notes

Tests will be added on the master branch.

@traefiker traefiker added this to the 1.5 milestone Mar 14, 2018
@ldez ldez changed the title fix: add lower-case passHostHeader key support. Add lower-case passHostHeader key support. Mar 14, 2018
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants