Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some examples #3150

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Update some examples #3150

merged 1 commit into from
Apr 9, 2018

Conversation

zaporylie
Copy link
Contributor

What does this PR do?

Explanation to one of the examples says Host but HostRegexp matcher rule in use.

Motivation

n/a

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

timoreimann
timoreimann approved these changes Apr 8, 2018
View reviewed changes
Copy link
Contributor

@timoreimann timoreimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@ldez ldez added this to the 1.6 milestone Apr 8, 2018
juliens
juliens approved these changes Apr 9, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zaporylie zaporylie requested review from a team as code owners April 9, 2018 08:51
@mmatur mmatur changed the base branch from master to v1.6 April 9, 2018 08:51
@traefiker traefiker merged commit 1de5111 into traefik:v1.6 Apr 9, 2018
@ldez ldez changed the title s/Host/HostRegexp Update some examples Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@timoreimann timoreimann timoreimann approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/documentation kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
7 participants
@zaporylie @juliens @timoreimann @nmengin @mmatur @ldez @traefiker