Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No template parsing on traefik configuration file #3347

Merged
merged 1 commit into from
May 22, 2018

Conversation

juliens
Copy link
Member

@juliens juliens commented May 18, 2018

What does this PR do?

We didn't try to do templating when the file (in the file provider) is the Træfik file configuration.

Motivation

Fixes #3268

More

  • Added/updated tests

@traefiker traefiker added this to the 1.6 milestone May 18, 2018
@juliens juliens force-pushed the fix-file-template branch from 200d097 to 6e62830 Compare May 18, 2018 11:40
@ldez ldez changed the title No templating on traefik configuration file in FileProvider No template parsing on traefik configuration file May 18, 2018
@juliens juliens force-pushed the fix-file-template branch 2 times, most recently from 2fa2baf to dd84509 Compare May 18, 2018 14:35
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful
LGTM
:shipit:

Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants