Serve TLS-Challenge certificate in first #3605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
status/2-needs-review
kind/bug/fix
traefiker
force-pushed
the
hotfix/tls-challenge-cert-in-first
branch
from
01d5ae8 to
7f19d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR modifies the order in the
getCertificateimplementations if ACME certificates can be generated tahnks toTLS-ALPNchallenge.Motivation
Users can have a generic wildcard self-signed certificate and want to serve a Let's Encrypt certificate only for few specific subdomains.
In the original order, it was not possible to generate a ACME certificate, thanks to the
TLS-ALPNchallenge, for a domain which is already cheked by a provided wildcard domain certificate.The new order checks if a temporary ACME certificate is enable for the requested domain before to check the others certifcates.
More
Additional Notes
Rename toml file in ACME E2E tests to be homogeneouse.