Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass the Authorization header to the backends #3606

Merged
merged 14 commits into from
Jul 16, 2018
Merged

Don't pass the Authorization header to the backends #3606

merged 14 commits into from
Jul 16, 2018

Conversation

jbdoumenjou
Copy link
Member

@jbdoumenjou jbdoumenjou commented Jul 12, 2018 •
edited
Loading

What does this PR do?

Add an option to remove the Authorization header for the basic and the digest authentication for the following providers :

  • File
  • k8s
  • Docker
  • Rancher
  • Consul Catalog
  • Marathon
  • Mesos
  • ECS
  • KV

Motivation

Fixes #3448

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

  • Fix the authentication documentation for the mesos and the marathon providers.
  • Add a unit test for the authentication configuration with segment labels for the marathon provider.

@jbdoumenjou jbdoumenjou requested review from a team as code owners July 12, 2018 13:46
@traefiker traefiker added this to the 1.7 milestone Jul 12, 2018
@ldez ldez removed request for a team July 12, 2018 15:52
@jbdoumenjou jbdoumenjou force-pushed the hotfix/remove_auth_header branch from a78bfd3 to 75c60f9 Compare July 16, 2018 08:25
juliens
juliens approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmatur
mmatur approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SantoDE
SantoDE approved these changes Jul 16, 2018
View reviewed changes
Copy link
Collaborator

@SantoDE SantoDE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👼

ldez
ldez approved these changes Jul 16, 2018
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 9ce444b into traefik:v1.7 Jul 16, 2018
@traefiker traefiker mentioned this pull request Jul 16, 2018
Closed
@ldez ldez added the kind/bug/fix a bug fix label Jul 16, 2018
@jbdoumenjou jbdoumenjou deleted the hotfix/remove_auth_header branch July 16, 2018 12:07
@kachkaev kachkaev mentioned this pull request Aug 1, 2018
Closed
@lukasmrtvy

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@mmatur mmatur mmatur approved these changes

@SantoDE SantoDE SantoDE approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/authentication area/middleware area/provider kind/bug/fix a bug fix size/L
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@jbdoumenjou @lukasmrtvy @juliens @SantoDE @mmatur @ldez @dtomcej @traefiker