Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent unparsable strings from being rendered in the Kubernetes template #3753

Merged
merged 2 commits into from
Aug 14, 2018
Merged

Prevent unparsable strings from being rendered in the Kubernetes template #3753

merged 2 commits into from
Aug 14, 2018

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Aug 9, 2018

What does this PR do?

Adds a parsing test to the ingress annotation to prevent unparsable strings being added into the provider template.

Motivation

Fixes #3731

More

  • Added/updated tests
  • Added/updated documentation - Not needed, bugfix

@dtomcej dtomcej requested a review from a team as a code owner August 9, 2018 19:13
@traefiker traefiker added this to the 1.7 milestone Aug 9, 2018
@dtomcej dtomcej changed the title Issue 3731 Prevent unparsable strings from being rendered in the Kubernetes template Aug 9, 2018
juliens
juliens approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Aug 14, 2018
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mmatur
mmatur approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmatur mmatur removed the request for review from a team August 14, 2018 14:28
@traefiker traefiker merged commit 278b318 into traefik:v1.7 Aug 14, 2018
@traefiker traefiker mentioned this pull request Aug 14, 2018
Closed
@kachkaev kachkaev mentioned this pull request Sep 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@mmatur mmatur mmatur approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@dtomcej @juliens @mmatur @nmengin @ldez @traefiker