Remove X-Forwarded-Uri and X-Forwarded-Method from untrusted IP #4036
+34
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geraldcroes
added
status/1-needs-design-review
kind/bug/fix
|
I've fixed the bug by just removing the additional headers before letting oxy/forward remove the other ones. I wanted to have a small changeset for 1.7, for the master the fix could easily be added in forwarded_header.go, which should make it more elegant as all forwarded headers are removed at the same place. |
ldez
suggested changes
Nov 7, 2018
comes from an untrusted ip. Failing to do so would result in an inconsistent and insecure behaviour for the forward authentication. If TrustForwardHeader is active in the forward auth, the auth endpoint receives these two headers if they have been sent from an untrusted ip. Whereas other X-Forward headers have been removed in the request and are safe to use in the auth endpoint.
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove X-Forwarded-Uri and X-Forwarded-Method headers if a request
comes from an untrusted IP.
Motivation
Failing to do so would result in an inconsistent and insecure behaviour
for the forward authentication. If TrustForwardHeader is active in the
forward auth, the auth endpoint receives these two headers if they
have been sent from an untrusted IP. Whereas other X-Forward headers
have been removed in the request and are safe to use in the auth
endpoint.
More
Additional Notes