Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter ECS tasks by LastStatus before adding to list of service tasks #4255

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Filter ECS tasks by LastStatus before adding to list of service tasks #4255

merged 2 commits into from
Dec 3, 2018

Conversation

hwhelan-CB
Copy link
Contributor

@hwhelan-CB hwhelan-CB commented Nov 29, 2018

What does this PR do?

Filters ECS tasks by their LastStatus, only adding them to the list of tasks if they are RUNNING

Motivation

Fixes #4249

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez

This comment has been minimized.

@hwhelan-CB hwhelan-CB requested review from a team as code owners November 29, 2018 20:33
@hwhelan-CB hwhelan-CB changed the base branch from master to v1.7 November 29, 2018 20:36
@mmatur mmatur removed request for a team November 30, 2018 15:36
@ldez ldez added this to the 1.7 milestone Nov 30, 2018
Copy link
Member

@mmatur mmatur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm totally agree with your fix.
Nice catch !! 👏
LGTM

@mmatur mmatur changed the title filter ECS tasks by LastStatus before adding to list of service tasks Filter ECS tasks by LastStatus before adding to list of service tasks Dec 3, 2018
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 31b8068 into traefik:v1.7 Dec 3, 2018
@ldez ldez mentioned this pull request Dec 4, 2018
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants