Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip TLS section with no secret in Kubernetes ingress #4340

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Skip TLS section with no secret in Kubernetes ingress #4340

merged 2 commits into from
Jan 8, 2019

Conversation

dtomcej
Copy link
Contributor

@dtomcej dtomcej commented Dec 27, 2018

What does this PR do?

Checks to see if a secret is defined in the TLS block of an ingress before attempting to load the secret. Logs a debug message if TLS section is skipped.

Motivation

Fixes #4280.

More

  • Added/updated tests
  • Added/updated documentation - None needed, intended behavior

@dtomcej dtomcej requested review from a team as code owners December 27, 2018 16:59
@dtomcej dtomcej changed the base branch from master to v1.7 December 27, 2018 16:59
@dtomcej dtomcej removed request for a team December 27, 2018 17:02
@ldez ldez added this to the 1.7 milestone Dec 27, 2018
ldez
ldez approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

geraldcroes
geraldcroes approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@geraldcroes geraldcroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Jan 8, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jan 8, 2019
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too... 😉

@traefiker traefiker merged commit e598d6b into traefik:v1.7 Jan 8, 2019
@ldez ldez mentioned this pull request Jan 8, 2019
Merged
16 tasks
@dtomcej dtomcej mentioned this pull request Jan 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@geraldcroes geraldcroes geraldcroes approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/provider/k8s/ingress kind/bug/fix a bug fix size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
7 participants
@dtomcej @juliens @geraldcroes @jbdoumenjou @ldez @nmengin @traefiker