Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Note about quotes for entrypoint definition with docker-compose #4390

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Note about quotes for entrypoint definition with docker-compose #4390

merged 1 commit into from
Jan 16, 2019

Conversation

Dragnucs
Copy link
Contributor

@Dragnucs Dragnucs commented Jan 13, 2019 •
edited
Loading

What does this PR do?

Motivation

More

  • Added/updated tests
  • Added/updated documentation

Additional Notes

@ldez ldez changed the title Update entrypoints.md Note about quotes for entrypoint definition with docker-compose Jan 13, 2019
@dduportal

This comment has been minimized.

Sign in to view
@Dragnucs Dragnucs requested review from a team as code owners January 14, 2019 16:32
@ldez ldez changed the base branch from master to v1.7 January 14, 2019 16:32
@ldez ldez removed request for a team January 14, 2019 16:32
@ldez ldez added this to the 1.7 milestone Jan 14, 2019
@ldez ldez added the kind/enhancement a new or improved feature. label Jan 14, 2019
@Dragnucs
Copy link
Contributor Author

Dragnucs commented Jan 14, 2019 •
edited by ldez
Loading

@dduportal as I see @ldez was way faster than me. Thank you.

ldez
ldez approved these changes Jan 16, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juliens
juliens approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@juliens juliens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jbdoumenjou
jbdoumenjou approved these changes Jan 16, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit d0cdb56 into traefik:v1.7 Jan 16, 2019
@ldez ldez mentioned this pull request Jan 30, 2019
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

@juliens juliens juliens approved these changes

Assignees
No one assigned
Labels
area/documentation area/provider/docker kind/enhancement a new or improved feature. size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@Dragnucs @dduportal @juliens @jbdoumenjou @ldez @traefiker