Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing information about statistics parameter #4393

Merged
merged 1 commit into from
Jan 14, 2019
Merged

Missing information about statistics parameter #4393

merged 1 commit into from
Jan 14, 2019

Conversation

decima
Copy link
Contributor

@decima decima commented Jan 14, 2019

What does this PR do?

  • adding details on documentation

Motivation

  • wrote to the slack channel because i coun't find this information, now changing the documentation to fix this problem and give a faster response to this problem.

More

  • Added/updated documentation

Additional Notes

thank you for what you all do team traefik :-)

@decima @ldez
doc missing information about statistics params
d6e9084 
I searched somewhere how to enable statistics, and I found it there, but without the context, you can't guess that --statistics is for --api.statistics
@decima decima requested review from a team as code owners January 14, 2019 15:13
@ldez ldez changed the base branch from master to v1.7 January 14, 2019 15:14
@ldez ldez removed request for a team January 14, 2019 15:14
@ldez ldez added this to the 1.7 milestone Jan 14, 2019
ldez
ldez approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nmengin
nmengin approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@nmengin nmengin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dduportal
dduportal approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks !

@traefiker traefiker merged commit 7d1edcd into traefik:v1.7 Jan 14, 2019
@ldez ldez changed the title doc missing information about statistics parameter Missing information about statistics parameter Jan 29, 2019
@ldez ldez mentioned this pull request Jan 30, 2019
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmengin nmengin nmengin approved these changes

@ldez ldez ldez approved these changes

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
area/documentation area/middleware/metrics size/S
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@decima @dduportal @ldez @nmengin @traefiker