Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing trailers with retry #4442

Merged
merged 3 commits into from
Feb 1, 2019
Merged

Missing trailers with retry #4442

merged 3 commits into from
Feb 1, 2019

Conversation

juliens
Copy link
Member

@juliens juliens commented Jan 30, 2019

What does this PR do?

When the retry middleware has already sent the headers, use the original headers map to be able to send trailers.

Motivation

Fix trailers and Grpc issues.
Fixes #4433

More

  • Added/updated tests

@traefiker traefiker added this to the 1.7 milestone Jan 30, 2019
ldez
ldez approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dtomcej
dtomcej suggested changes Jan 31, 2019
View reviewed changes
middlewares/retry.go Outdated Show resolved Hide resolved
middlewares/retry.go Outdated Show resolved Hide resolved
middlewares/retry.go Outdated Show resolved Hide resolved
dtomcej
dtomcej approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@dtomcej dtomcej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
:shipit:

jbdoumenjou
jbdoumenjou approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@jbdoumenjou jbdoumenjou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 76c9cea into traefik:v1.7 Feb 1, 2019
@traefiker traefiker mentioned this pull request Feb 1, 2019
Closed
@ldez ldez changed the title fix missing trailers with retry Missing trailers with retry Feb 11, 2019
@ldez ldez mentioned this pull request Feb 13, 2019
Merged
12 tasks
@juliens juliens deleted the fix/retry-trailers branch September 6, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtomcej dtomcej dtomcej approved these changes

@ldez ldez ldez approved these changes

@jbdoumenjou jbdoumenjou jbdoumenjou approved these changes

Assignees
No one assigned
Labels
area/middleware kind/bug/fix a bug fix
Projects
None yet
Milestone
1.7
Development

Successfully merging this pull request may close these issues.
5 participants
@juliens @jbdoumenjou @ldez @dtomcej @traefiker