-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated link to Kubernetes.io in README.md #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch LGTM
@oscerd thanks for noticing :) |
I updated the commit date and pushed again |
It doesn't seems to need a rebase, but maybe I'm losing something :-) |
The problem seems to be with this [ERROR] Failed to set version on github.com/mailgun/manners to fada45142db3f93097ca917da107aa3fad0ffcb5: Unable to update checked out version |
Let me know if it's my fault |
OK, this issue is solved on branch 1.1, can you rebase on this branch? I just changed your PR to v1.1 branch. Thanks :) |
@emilevague, sorry for this, I was looking at master branch. Sorry :-) |
My fault anyway :-D |
Rebased again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
Thanks. It was a minor problem :-) |
Just removed a duplicated link into README. Nothing really important :-)