-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [GROOT-1550] add support for taxonomy PUT methods #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiamStokingerContentful
requested review from
mayakarabula,
AdrianLThomas,
maxcheremisin and
momenzadehvida
November 8, 2024 15:24
maxcheremisin
previously approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mayakarabula
previously approved these changes
Nov 8, 2024
3 tasks
LiamStokingerContentful
dismissed stale reviews from mayakarabula and maxcheremisin
via
November 19, 2024 12:12
b61d95e
…axonomy (#2469) * feat: [GROOT-1550] introduce proposal for fixing update behavior in taxonomy * chore: [GROOT-1550] remove default version for taxonomy updates
LiamStokingerContentful
force-pushed
the
GROOT-1550
branch
from
November 19, 2024 15:42
b61d95e
to
ce210b9
Compare
AdrianLThomas
approved these changes
Nov 20, 2024
jjolton-contentful
approved these changes
Nov 20, 2024
mgoudy91
approved these changes
Nov 20, 2024
🎉 This PR is included in version 11.39.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces new
createWithId
methods for upcoming taxonomyPUT
endpoints on concepts and concept schemesdocs: https://github.com/contentful/doc-app/pull/3300
Description
This extends current
concept
andconceptScheme
entities withcreateWithId
methods, which will expose access to newPUT
endpointsMotivation and Context
Users want to be able to create taxonomies from external systems and link them easily with a shared ID. Currently with our POST methods, we generate a base 62 converted UUID as the sole ID for a concept or concept scheme.
Checklist (check all before merging)
When adding a new method:
./lib/export-types.ts