Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing typing #1219

Merged
merged 1 commit into from
Jun 21, 2023
Merged

fix: Add missing typing #1219

merged 1 commit into from
Jun 21, 2023

Conversation

jimishshah
Copy link

@jimishshah jimishshah commented Jun 21, 2023

Summary

Add missing type in transformEntryForLocale function

Description

Motivation and Context

This pr #1212 was merged and released but it missed to add the types in index.d.ts file, this gives following typescript error in client code.

Type '(from: any, currentLocale: any, { id: entryId }: { id: any; }) => Promise<any>' is not assignable to type '(fromFields: ContentFields, currentLocale: string) => any'.
  Target signature provides too few arguments. Expected 3 or more, but got 2.ts(2322)

Todos

  • Implemented feature
  • Feature with pending implementation

Screenshots (if appropriate):

@jimishshah jimishshah requested a review from a team as a code owner June 21, 2023 10:30
@marcolink
Copy link
Member

@jimishshah thanks for your contribution 🎉

Will merge after CI run passed successfully :)

@marcolink marcolink changed the title Add missing typing fix: Add missing typing Jun 21, 2023
@marcolink marcolink merged commit 46cfd51 into contentful:master Jun 21, 2023
@contentful-automation
Copy link

🎉 This PR is included in version 4.13.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants