Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): add configureEntryEditors definition #1222

Conversation

nschirmer
Copy link
Contributor

@nschirmer nschirmer commented Jun 23, 2023

Summary

As mentioned in issue #1221, the type definition for configureEntryEditors is missing.

I also added editor-builtin as an option for widgetNamespace for these entry editors. I'm not entirely sure if builtin is still a possible choice for these, given that it does seem to require editor-builtin, but I've left the choice there.

@nschirmer nschirmer requested a review from a team as a code owner June 23, 2023 19:01
@marcolink marcolink force-pushed the add-configureentryeditors-to-type-defs branch from a872651 to 347f15c Compare October 20, 2023 15:03
@jjolton-contentful jjolton-contentful force-pushed the add-configureentryeditors-to-type-defs branch from 347f15c to 1513c41 Compare October 4, 2024 16:50
@jjolton-contentful jjolton-contentful requested a review from a team as a code owner October 4, 2024 16:50
Copy link
Contributor

@jjolton-contentful jjolton-contentful left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for the contribution @nschirmer

@jjolton-contentful jjolton-contentful merged commit 584b879 into contentful:main Oct 4, 2024
2 checks passed
@contentful-automation
Copy link

🎉 This PR is included in version 4.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants