feat: improve request throttling [ZEND-4197] #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruderngespra
approved these changes
Oct 12, 2023
| @@ -56,11 +70,14 @@ export const createMakeRequest = (client: PlainClientAPI, { spaceId, environment | |||
| const { url, ...config } = requestConfig | |||
| const fullUrl = makeBaseUrl(url) | |||
|
|
|||
| return client.raw.http(fullUrl, config) | |||
| return throttle(() => client.raw.http(fullUrl, config))() | |||
There was a problem hiding this comment.
Do I get this correctly that createMakeRequest is the only constructor in this project that creates functions which trigger API requests (makeRequest instances), and by wrapping the throttle here we effectively throttle all requests, both for the fetching in preparation of the migration as well as for the applying of the changes in the migration, because wherever api interactions happen they do with makeRequest?
Would like to first get a customer confirmation that it all works as expected |
marcolink
force-pushed
the
feat/improve-request-throttling
branch
from
89f0355 to
c493ec7
Compare
|
🎉 This PR is included in version 4.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't have a good way of throttling big amount of requests. For other tools we already use pQueue or pThrottle to limit the number of requests/s. This is mostly relevant for migration with transform functions on entries, as the amount of affected entities can easily be > 1000.
This changes introduces a new CLI flag
request-limit(defaults to10, as this is the smallest limit from our free offering) which describes the max amount of requests this tool initiates within a second.