Bug fix for makeRequest base URL logic #1273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoudy91
approved these changes
Nov 28, 2023
|
@mgoudy91 This PR still shows a "test-and-release" check waiting for status - anything I can do to get it closed and merged? |
|
🎉 This PR is included in version 4.18.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the URL passed to Axios by makeRequest
Description
When you use the makeRequest function in a JS migration script, I encountered a URL not found error because the current makeBaseUrl function does not prepend the protocol and domain to the URL.
Motivation and Context
I'm trying to set up a CI/CD pipeline for a Contentful project. I need the makeRequest function for a migration.