Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deriveEntry): n to n #138

Merged
merged 9 commits into from
Sep 21, 2018
Merged

feat(deriveEntry): n to n #138

merged 9 commits into from
Sep 21, 2018

Conversation

phoebeschmidt
Copy link
Contributor

fixes #127

Summary

When the reference field for a deriveEntry migration is an array of linked entries, the derived entry now becomes the first item in an array. (Previously, the derived entry was linked as a single entry, ignoring the type of the reference field). Also add a new example showing this behavior.

@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #138 into master will increase coverage by 5.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   68.61%   73.99%   +5.37%     
==========================================
  Files          75       75              
  Lines        2014     1969      -45     
  Branches      233      225       -8     
==========================================
+ Hits         1382     1457      +75     
+ Misses        542      439     -103     
+ Partials       90       73      -17
Impacted Files Coverage Δ
src/lib/action/entry-derive.ts 77.35% <100%> (+71.23%) ⬆️
src/lib/intent/entry-derive.ts 33.33% <0%> (-9.53%) ⬇️
src/lib/intent/field-move.ts 54.16% <0%> (-7.91%) ⬇️
src/lib/intent/content-type-delete.ts 83.33% <0%> (-2.39%) ⬇️
src/lib/migration-steps/dispatch-proxy.ts 83.33% <0%> (-2.39%) ⬇️
src/lib/migration-steps/action-creators.ts 92.85% <0%> (-1.27%) ⬇️
src/lib/intent/content-type-create.ts 100% <0%> (ø) ⬆️
src/lib/migration-steps/first-external-caller.js 100% <0%> (ø) ⬆️
src/lib/offline-api/index.ts 81.17% <0%> (+2.94%) ⬆️
src/lib/intent/entry-transform.ts 81.81% <0%> (+3.24%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 282d892...296b49c. Read the comment docs.

@phoebeschmidt phoebeschmidt requested review from axe312ger and Khaledgarbaya and removed request for axe312ger September 21, 2018 12:56
@phoebeschmidt phoebeschmidt merged commit 7186467 into master Sep 21, 2018
@phoebeschmidt phoebeschmidt deleted the feat/n-to-n branch September 21, 2018 13:50
@phoebeschmidt
Copy link
Contributor Author

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use deriveLinkedEntries with many references field needs documentation.
2 participants