-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(deriveEntry): n to n #138
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #138 +/- ##
==========================================
+ Coverage 68.61% 73.99% +5.37%
==========================================
Files 75 75
Lines 2014 1969 -45
Branches 233 225 -8
==========================================
+ Hits 1382 1457 +75
+ Misses 542 439 -103
+ Partials 90 73 -17
Continue to review full report at Codecov.
|
phoebeschmidt
requested review from
axe312ger and
Khaledgarbaya
and removed request for
axe312ger
September 21, 2018 12:56
Khaledgarbaya
approved these changes
Sep 21, 2018
🎉 This PR is included in version 0.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #127
Summary
When the reference field for a deriveEntry migration is an array of linked entries, the derived entry now becomes the first item in an array. (Previously, the derived entry was linked as a single entry, ignoring the type of the reference field). Also add a new example showing this behavior.