Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(validations): do not require min and max size validation #151

Merged
merged 4 commits into from
Nov 28, 2018

Conversation

phoebeschmidt
Copy link
Contributor

Relax migration tool validations for min/max size field validations. Now they are not required, but still nullable.

@codecov
Copy link

codecov bot commented Nov 27, 2018

Codecov Report

Merging #151 into master will decrease coverage by 4.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
- Coverage   88.44%   84.38%   -4.07%     
==========================================
  Files          80       80              
  Lines        2060     2145      +85     
  Branches      229      242      +13     
==========================================
- Hits         1822     1810      -12     
- Misses        194      260      +66     
- Partials       44       75      +31
Impacted Files Coverage Δ
...e-api/validator/schema/field-validations-schema.ts 100% <ø> (ø) ⬆️
.../lib/offline-api/validator/schema/fields-schema.ts 58.33% <0%> (-41.67%) ⬇️
src/lib/intent-validator/field-movement.ts 63.15% <0%> (-36.85%) ⬇️
src/lib/migration-chunks/validation/field.ts 67.36% <0%> (-31.09%) ⬇️
src/lib/intent/editorinterface-reset.ts 40% <0%> (-24.29%) ⬇️
src/lib/intent/editorinterface-copy.ts 45% <0%> (-21.67%) ⬇️
src/lib/offline-api/validator/errors.ts 74.19% <0%> (-18.12%) ⬇️
src/lib/migration-steps/action-creators.ts 90% <0%> (-10%) ⬇️
src/lib/intent/field-create.ts 91.66% <0%> (-8.34%) ⬇️
src/lib/intent/content-type-delete.ts 92.85% <0%> (-7.15%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86df67...5effa48. Read the comment docs.

Copy link
Contributor

@Khaledgarbaya Khaledgarbaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change

test/end-to-end/validations.spec.js Outdated Show resolved Hide resolved
@phoebeschmidt phoebeschmidt merged commit 99b4976 into master Nov 28, 2018
@phoebeschmidt phoebeschmidt deleted the fix/size-range-validations branch November 28, 2018 14:52
@phoebeschmidt
Copy link
Contributor Author

🎉 This PR is included in version 0.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants