fix ContentTransformIntentValidator #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shouldPublish should accept 'preserve' in addition to boolean values
TimBeyer
previously approved these changes
Jan 4, 2019
5 tasks
|
I guess we also need to add this for |
|
And actually Must have missed this during the review. |
|
@TimBeyer Also, this makes the content-transform.spec.ts test to fail, because the error message from the validation is now different at |
TimBeyer
reviewed
Jan 7, 2019
| @@ -157,7 +157,7 @@ describe('Content transformation', function () { | |||
| type: 'contentType/transformEntries' | |||
| } | |||
| }, | |||
| message: '"string" is not a valid type for the content transformation property "shouldPublish". Expected "boolean".', | |||
| message: '"undefined" is not a valid type for the content transformation property "shouldPublish". Expected "alternatives".', | |||
There was a problem hiding this comment.
This new error message isn't really useful anymore for people.
Maybe we could figure out in
Joi.alternatives and figure out the different types that are allowed.Either that, or somehow change the message for the
alternatives validation so that it doesn't say Expected "alternatives".
There was a problem hiding this comment.
@TimBeyer error message fixed with tests
Khaledgarbaya
approved these changes
Jan 9, 2019
TimBeyer
approved these changes
Jan 9, 2019
|
👏 |
|
🎉 This PR is included in version 0.16.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
shouldPublish should accept 'preserve' in addition to boolean values
Description
Add 'preserve' as a valid option to validations for shouldPublish field
Motivation and Context
#143 (comment)