fix: editorInterface methods do not reset custom sidebar anymore #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suevalov
changed the title
suevalov
force-pushed
the
add-custom-sidebar-support
branch
2 times, most recently
from
76b0b7d to
264987d
Compare
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
==========================================
+ Coverage 84.72% 88.68% +3.95%
==========================================
Files 84 84
Lines 2330 2244 -86
Branches 272 259 -13
==========================================
+ Hits 1974 1990 +16
+ Misses 270 201 -69
+ Partials 86 53 -33
Continue to review full report at Codecov.
|
suevalov
force-pushed
the
add-custom-sidebar-support
branch
from
264987d to
c63c4dc
Compare
suevalov
force-pushed
the
add-custom-sidebar-support
branch
from
c63c4dc to
f6976ff
Compare
suevalov
changed the title
|
@Khaledgarbaya I think it's quite accurate at the moment. In this PR we're addressing the problem that the tool does what is not intended to happen (rewrites There will be an another PR which adds possibility to |
|
🎉 This PR is included in version 0.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #173
Description
editorInterfacepayload can have custom sidebar configuration saved. Currently all related methods just overridesidebarconfiguration. This PR fixes the behavior, so ifsidebarconfiguration isn't overwritten if present in the initial payload.