fix(proxy): allow proxy options in argv #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- Thank you for reporting an issue. Please fill in as much of the template below as you're able. Feel free to delete any section you want to skip. PLEASE **DO NOT** share any credentials related to your Contentful account like <space_id> or <access_token>. If this is an urgent issue you are having with Contentful It's better to contact [[email protected]](mailto:[email protected]). --> ## Summary Allows `proxy` and `rawProxy` in argv.
phoebeschmidt
changed the title
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=========================================
- Coverage 84.65% 84.4% -0.26%
=========================================
Files 84 84
Lines 2333 2340 +7
Branches 274 277 +3
=========================================
Hits 1975 1975
- Misses 271 278 +7
Partials 87 87
Continue to review full report at Codecov.
|
zcei
approved these changes
Apr 20, 2019
Khaledgarbaya
approved these changes
Apr 22, 2019
|
🎉 This PR is included in version 0.17.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that caused unauthenticated proxies to fail (if the proxy doesn't require a user/pw).
We released it as beta to confirm it fixes the user issue (since enterprise proxies are unique and challenging to debug). It did, so let's get this into the regular release of contentful-migration.