fix(stable-results): Order results to protect against changing result… #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set ordering. Increase page size for better performance
matthew-contentful
force-pushed
the
fix/stable-results
branch
from
1d6a604 to
8ae6b75
Compare
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
=======================================
Coverage 86.79% 86.79%
=======================================
Files 97 97
Lines 2666 2666
Branches 321 321
=======================================
Hits 2314 2314
Misses 257 257
Partials 95 95
Continue to review full report at Codecov.
|
TimBeyer
approved these changes
Nov 4, 2019
| @@ -151,6 +151,8 @@ export default class Fetcher implements APIFetcher { | |||
|
|
|||
| while (true) { | |||
| const paramsWithSkip = { | |||
| limit: '500', | |||
There was a problem hiding this comment.
Maybe let's factor this out into a constant so we can adapt this in the future without having to manually change all these tests another time
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… set ordering. Increase page size for better performance