feat: support wildcard domains with regex [MONET-2345] #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasKiers
requested changes
Oct 1, 2024
| '^(?:' + | ||
| '(?:' + | ||
| '(?:\\*\\.)?(?:[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?\\.)+[a-zA-Z]{2,6}' + | ||
| '|\\*\\.[a-zA-Z]{2,6}' + // Matches wildcard domains like *.com |
There was a problem hiding this comment.
It should allow wildcards like *.example.com but not allow *.com, * or *.too.example.com
|
@BasKiers updated 🫡 |
BasKiers
approved these changes
Oct 2, 2024
jjolton-contentful
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
We already support wildcard in allow networks Cloudflare. This PR allows users using this feature while creating an app with functions that has
allowNetworksattribute.We update the regex that we use to validate networks.