Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small changes to validate key mapping documentation and no assert when compiling with CMAKE_BUILD_TYPE None #1717

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Small changes to validate key mapping documentation and no assert when compiling with CMAKE_BUILD_TYPE None #1717

wants to merge 1 commit into from

Conversation

Yaraslaut
Copy link
Member

Closes #1622
Also, remove assertions when compiling on arch linux with CMAKE_BUILD_TYPE None

@Yaraslaut Yaraslaut added the no changelog Tells the CI to not require a changelog entry label Jan 27, 2025
@github-actions github-actions bot added frontend Contour Terminal Emulator (GUI frontend) CMake labels Jan 27, 2025
@Yaraslaut Yaraslaut force-pushed the improvement/small_tweaks branch from ad306ae to d7c03ba Compare January 27, 2025 21:29
@github-actions github-actions bot added the CI GitHub Actions & CI label Jan 27, 2025
@Yaraslaut Yaraslaut changed the title Small changed to ensure key mapping configuration and no assert on ar… Small changes to validate key mapping documentation and no assert when compiling with CMAKE_BUILD_TYPE None Jan 27, 2025
@Yaraslaut Yaraslaut force-pushed the improvement/small_tweaks branch from d7c03ba to e867602 Compare January 27, 2025 21:55
@Yaraslaut Yaraslaut force-pushed the improvement/small_tweaks branch from e867602 to f6fcc59 Compare January 27, 2025 21:55
christianparpart
christianparpart approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@christianparpart christianparpart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed. thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianparpart christianparpart christianparpart approved these changes

Assignees
No one assigned
Labels
CI GitHub Actions & CI CMake frontend Contour Terminal Emulator (GUI frontend) no changelog Tells the CI to not require a changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate configuration documentation
2 participants
@Yaraslaut @christianparpart