Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more flexible React peer dependency range #12

Merged
merged 1 commit into from
Mar 30, 2015

Conversation

colindresj
Copy link
Contributor

Allows for React v0.13.x while maintaining v0.12.x support

@yocontra
Copy link
Owner

not sure this is good, this will allow for anything above 0.13 as well even though we dont know if it will work with that. the range should me ~0.12.0-0.13.0 or something

@colindresj
Copy link
Contributor Author

The safety concern around future major releases makes sense, but wouldn't we run into problems on 0.13.x releases with a ~0.12.0-0.13.0 range? How do you feel about ^0.12.0 || ~0.13.0?

@yocontra
Copy link
Owner

~0.12.0 || ~0.13.0 makes the most sense, I agree

  * Allows for React v0.13.x while maintaining v0.12.x support
@colindresj
Copy link
Contributor Author

Cool, PR updated

@jpsfs
Copy link

jpsfs commented Mar 30, 2015

+1 having this issue.
Can you plz accept the PR?

yocontra pushed a commit that referenced this pull request Mar 30, 2015
Provide more flexible React peer dependency range
@yocontra yocontra merged commit 38be7c6 into yocontra:master Mar 30, 2015
@yocontra
Copy link
Owner

Published as 0.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants