Fix bug where string would cause invariant error. #51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that the switch to React.Children exposed.
Children were always either being wrapped or cloned due to the fact that the
props
object existed even when there were no keys. Before using React.Children to check length for wrapping, we were usingprops.children.length
which when it was a string, it'slength
property would force it to be wrapped. UsingReact.Children.count
no longer allowed this to happen and since the props object was truthy, it would try to clone the text node which caused an invariant error.The first fix is to check the length the keys array for the props object instead of the truthiness of the props object itself. This allows text nodes to be rendered unless there are props to merge which would still cause an error. In this case we want to wrap the text node so any lingering props can be passed to the wrapping component.
Modified the sample to expose this.