Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config is not found with scoped package #596

Closed
1 of 4 tasks
thomasthiebaud opened this issue Mar 19, 2019 · 5 comments · Fixed by #597
Closed
1 of 4 tasks

Config is not found with scoped package #596

thomasthiebaud opened this issue Mar 19, 2019 · 5 comments · Fixed by #597
Labels

Comments

@thomasthiebaud
Copy link

thomasthiebaud commented Mar 19, 2019

I createad a package called conventional-changelog-lint-config-<companyname>. I would like to use it like

{
  "extends": ["<companyname>"]
}

But it is a private for now and it is scoped using @<companyname>, so to use it I have to write the full name

{
  "extends": ["@<companyname>/conventional-changelog-lint-config-<companyname>"]
}

It works, but it is quite annoying. Is there an easy to fix that?

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Your Environment

Executable Version
commitlint --version 7.5.2
git --version git version 2.17.2 (Apple Git-113)
node --version v10.15.1
@byCedric
Copy link
Member

byCedric commented Mar 20, 2019

We can adopt the ESLint method for scoped packages. I think that would suit your needs right? Also looking at @escapedcat 😉

If we are going for that one, you can use it as @<companyname>. The package should be named something like @<companyname>/commitlint-config.

@byCedric
Copy link
Member

byCedric commented Mar 20, 2019

Created a PR with the change for scoped short notations! 🎉 Hope you like it.

Btw, I noticed that you are using a legacy naming convention for the package. It was changed from conventional-changelog-lint-config to commitlint-config. Please note that if this PR with the feature is merged, your legacy-named package will not work with the short scope notation.

@thomasthiebaud
Copy link
Author

Hi, thanks a lot for all the quick answers. I can rename my package to follow the new convention, no problem with that 🎉

@byCedric
Copy link
Member

No worries, happy to help 😄 We'll try to get a version out asap, but we need to fix some weird behavior with some dependencies first.

@byCedric
Copy link
Member

Quick status update, we have fixed the strange behavior of one of our dependencies. But to get everything going in the right direction, we need to fix #599 before we should release a new one. That issue is also blocked by comsiconfig#180. Bare with us here 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 participants