Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --sign flag to sign git commit and tag #29

Merged
merged 2 commits into from
May 1, 2016

Conversation

nexdrew
Copy link
Member

@nexdrew nexdrew commented Apr 29, 2016

Builds on top of (and replaces) #18, with the following additions:

  • Sign the commit as well as the tag
  • Change the CLI option to --sign (instead of --sign-tag) and update the description
  • Add a test that verifies GPG signing was attempted by git (and failed from lack of key)

@bcoe
Copy link
Member

bcoe commented May 1, 2016

@nexdrew if you get two seconds, mind rebasing this and we'll land it; if you don't get to it I can create a branch for merging later tonight.

@nexdrew
Copy link
Member Author

nexdrew commented May 1, 2016

@bcoe Working on it

Conaclos and others added 2 commits May 1, 2016 17:34
By default, a tag is not signed (git tag -a).
The option `--sign-tag` enables tag signing (git tag -s).
@coveralls
Copy link

coveralls commented May 1, 2016

Coverage Status

Coverage increased (+1.7%) to 91.566% when pulling de84720 on nexdrew:signing into 3f51e94 on conventional-changelog:master.

@nexdrew
Copy link
Member Author

nexdrew commented May 1, 2016

@bcoe Rebased. I was wondering why coverage showed 100% when my --sign test never makes it to the git tag -s call. :P

@addaleax
Copy link

addaleax commented May 1, 2016

@nexdrew See the shelljs issue @bcoe linked above – I’ll be posting an explanation there shortly :)

@bcoe
Copy link
Member

bcoe commented May 1, 2016

@nexdrew thanks for rebasing. @addaleax great find, hopefully we can get that upstreamed this week.

@bcoe bcoe merged commit de758bc into conventional-changelog:master May 1, 2016
@nexdrew nexdrew deleted the signing branch May 2, 2016 12:52
@nexdrew
Copy link
Member Author

nexdrew commented May 2, 2016

Perhaps mocking the git bin just for the --sign test would be a better alternative to expecting a failure on the commit (which preempts the tag)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants