Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stop suggesting npm publish if package.json was not updated #319

Merged
merged 2 commits into from
May 6, 2019
Merged

fix: stop suggesting npm publish if package.json was not updated #319

merged 2 commits into from
May 6, 2019

Conversation

MiniGod
Copy link
Contributor

@MiniGod MiniGod commented Mar 28, 2019

[email protected] introduced git tag fallback, but it is still suggesting npm publish even if package.json was not updated.

Added a check so it doesn't. Could later be generalized for bower and composer, etc...?

Did a small refactor in bump.js so that the check would be simpler.

@coveralls
Copy link

coveralls commented Mar 28, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 34aadcc on MiniGod:dont-suggest-npm-publish-if-no-package-json into aed52f2 on conventional-changelog:master.

stevemao
stevemao approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@stevemao stevemao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Thanks for the PR!

@bcoe
Copy link
Member

bcoe commented Apr 9, 2019

@MiniGod agreed, great addition; mind rebasing?

bcoe
bcoe approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as you rebase.

@MiniGod MiniGod force-pushed the dont-suggest-npm-publish-if-no-package-json branch 2 times, most recently from 427b891 to 073ad8b Compare April 17, 2019 21:56
@MiniGod
Copy link
Contributor Author

MiniGod commented Apr 17, 2019

rebased, but tests failing bc of lint errors of some other code (probably caused by the timing of #320 & #321). I'll rebase again when that's fixed on master.

@bcoe
Copy link
Member

bcoe commented May 5, 2019

@MiniGod I apologize for the slow turn around, master should be fixed again, mind rebasing one final time?

@MiniGod MiniGod force-pushed the dont-suggest-npm-publish-if-no-package-json branch from 073ad8b to f0642f9 Compare May 5, 2019 19:42
@MiniGod MiniGod force-pushed the dont-suggest-npm-publish-if-no-package-json branch from f0642f9 to 34aadcc Compare May 5, 2019 23:04
@MiniGod
Copy link
Contributor Author

MiniGod commented May 5, 2019

It's ready for you now.

@bcoe bcoe merged commit a5ac845 into conventional-changelog:master May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevemao stevemao stevemao approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiniGod @coveralls @bcoe @stevemao