-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The order of the tuples on a task getting inputs from other tasks depends on Copper's internal scheduling #187
Comments
I can work on this but I want to clarify what the fix should be. Before I investigate any further, I wanted to know if changing this behavior to sort by the order the inputs appear in the cnx array would be enough to close this issue? That's the order I would expect naturally(and maybe most users). |
I think the order of declaration of the cnx should work. I want to be sure that we are covering the use cases so maybe we should start making some unit test set to be sure we don't break something :) I thought about the second solution but getting a list might be weird because it forces the users to do some kind of array association: Do you have another syntax in mind? |
That was the first syntax I thought of, but an alternative would be something like:
Either way, I agree with the unit testing, so I'm going to start with a PR just with the unit test while I think about the proper solution. |
Just some food for thoughts for you ...there is a strange asymmetry with the combined syntax: |
For example:
type Input = input_msg!('cl, ImageRGBU8Msg, ImageRGBU8Msg, ImageGrayU8Msg);
ortype Input = input_msg!('cl, ImageRGBU8Msg, ImageGrayU8Msg, ImageRGBU8Msg);
for rerun is not obvious at first glance from:The text was updated successfully, but these errors were encountered: