ctlv3: fix migration #6794
Merged
ctlv3: fix migration #6794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
also cc @timothysc |
xiang90
force-pushed
the
fix_migration
branch
from
fc8e849
to
2ba4299
Compare
|
Tested and verified all three cases. Code also LGTM. |
|
OK - I also did some tests and it seems to fix my problems @xiang90 - however, we need backport to 3.0 branch (fortunately backport seems to be trivial) |
|
Cool - that would be great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @wojtek-t @hongchaodeng
I tested the example data @wojtek-t provided. It fixed the problem. I do not really have time to test this with more extensive data set now.
Please try with more data set.
WAL + no snap (new k8s cluster); WAL+snap (long running k8s cluster); fresh snap (new cluster data forced by --snapshot-count==1)
Thanks!