Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't growfs if we're going to autosave anyway #1847

Open
jlebon opened this issue Dec 3, 2024 · 0 comments
Open

Don't growfs if we're going to autosave anyway #1847

jlebon opened this issue Dec 3, 2024 · 0 comments

Comments

@jlebon
Copy link
Member

jlebon commented Dec 3, 2024

Currently, we do ignition-ostree-growfs and then in ignition-ostree-transposefs-save.service check if the agcount exceeds the threshold to know if to kick in the autosave feature. The problem is that growing the rootfs will cause any mounting of the rootfs to be extremely slow.

We should instead just have ignition-ostree-growfs not do the actual filesystem growing (but still do the partition growing) if it detects that it would meet the threshold and e.g. drop a file for ignition-ostree-transposefs-save.service to know that it needs to autosave (or have the latter figure it out on its own if that's easier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant