Add Zenrock Mainnet #5646
Add Zenrock Mainnet #5646
Conversation
| "chain_type": "cosmos", | ||
| "pretty_name": "Zenrock Mainnet", | ||
| "chain_id": "diamond-1", | ||
| "bech32_prefix": "zen", |
There was a problem hiding this comment.
zen is taken by Zen protocol?? https://github.com/satoshilabs/slips/blob/master/slip-0173.md
At line: https://github.com/satoshilabs/slips/blob/master/slip-0173.md?plain=1#L293
There was a problem hiding this comment.
Bech32 prefixes are not meant to be exclusive, no?
We haven't seen it in the chain registry here either
There was a problem hiding this comment.
This topic was recently discussed and there did turn out to be some issues when two chains shared a bech32 prefix, although that may have been limited to bech32 prefixes actually on the Chain Registry.
However we generally require that all chains register their prefix to that SLIP0173 page once it reaches mainnet, and its probably best to not have any collisions.
| ] | ||
| }, | ||
| "logo_URIs": { | ||
| "png": "https://raw.githubusercontent.com/cosmos/chain-registry/master/zenrock/images/zenrock.png" |
There was a problem hiding this comment.
And add the svg here
This PR adds Zenrock Mainnet (
diamond-1) to the chain registry and updates images for testnet.