edit-validator defaults moniker to moniker in config.toml, not [do-not-modify]

[doggystylez]

Summary of Bug

Seems to have been reported in #2423

Changing the validator info with tx edit-validator without providing moniker flag defaults it to the moniker set in config.toml, not [do-not-modify] as noted in the CLI

Version

server_name: gaiad
version: v7.0.2
cosmos_sdk_version: v0.45.4
tendermint: v0.34.19

Steps to Reproduce

Start local test chain with gaiad v7.0.2, setting validator moniker in gentx to "test-0".
Query validators and note that the moniker is "test-0"
Stop gaiad and edit moniker in config.toml to "test-1"
Restart gaiad and submit a edit-validator transaction, such as gaiad tx staking edit-validator --details "test". Moniker flag is omitted.
Query validators and now moniker is "test-1"

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged
• Contributor assigned/self-assigned

[alexanderbez]

@julienrbrt could you verify this by any chance please? Thanks!

[julienrbrt]

I have a few other things to finish before, @likhita-809 can already have a look 🙏

[likhita-809]

@alexanderbez this issue is getting resolved when we change the flag name to some other name instead of moniker, is this the right way to fix ?

[likhita-809]

@alexanderbez we already have a fix for this here: #10684
But I think we can't backport it since it is CLI breaking,

[alexanderbez]

@alexanderbez we already have a fix for this here: #10684 But I think we can't backport it since it is CLI breaking,

@likhita-809 I actually think it's OK to backport to v0.45 and v0.46 -- It's a bug fix and that's OK 👍

Let's backport and close this issue

[likhita-809]

@alexanderbez we already have a fix for this here: #10684 But I think we can't backport it since it is CLI breaking,

@likhita-809 I actually think it's OK to backport to v0.45 and v0.46 -- It's a bug fix and that's OK +1

Let's backport and close this issue

do you want to backport this @alexanderbez ?

[likhita-809]

resolved in #12317