Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rosetta: break cyclical dependency with cosmos-sdk #14041

Closed
Tracked by #14007
tac0turtle opened this issue Nov 28, 2022 · 1 comment · Fixed by #14062
Closed
Tracked by #14007

rosetta: break cyclical dependency with cosmos-sdk #14041

tac0turtle opened this issue Nov 28, 2022 · 1 comment · Fixed by #14062
Assignees
Labels
C:Rosetta Issues and PR related to Rosetta dependencies Pull requests that update a dependency file

Comments

@tac0turtle
Copy link
Member

Summary

Currently cosmos-sdk depends on rosetta (an external go.mod) and rosetta depends on Cosmos-sdk.

I believe we only need to break the sdk side and this is scoped to the server start command.

The problem arises with that rosetta is imported into the server package instead of passed in by the app.

@tac0turtle tac0turtle added dependencies Pull requests that update a dependency file C:Rosetta Issues and PR related to Rosetta labels Nov 28, 2022
@tac0turtle
Copy link
Member Author

Talked with the team, we believe not having rosetta run as part of the node process is the best solution here. It breaks the dependency graph and removes operation of it from the node. Therefore it could be easier to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:Rosetta Issues and PR related to Rosetta dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants