Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI flags and helpers for governance proposals #14700

Closed
SpicyLemon opened this issue Jan 19, 2023 · 0 comments · Fixed by #14718
Closed

CLI flags and helpers for governance proposals #14700

SpicyLemon opened this issue Jan 19, 2023 · 0 comments · Fixed by #14718
Assignees

Comments

@SpicyLemon
Copy link
Collaborator

Summary

Create some flags and helper functions for commands to use when the command is for submitting a governance proposal.

Problem Definition

With the changes in the gov module, specifically the deprecation of modules adding sub-commands to tx gov, having CLI commands to submit specific governance proposals is left to each module. But all of them will need a common set of options, e.g. deposit, and will always need a MsgSubmitProposal with those fields.

Proposal

  1. Create public flag variables for deposit, metadata, title, and summary.
  2. Create a helper function that adds them to a command (similar to AddPaginationFlagsToCmd).
  3. Create a helper function that reads the flags them and returns a MsgSubmitProposal with appropriate fields populated (similar to ReadPageRequest). This should also populate the proposer field using the --from flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant