Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improperly formatted proto file causes ORDER_BY_DESC enum to be parsed incorrectly #15437

Closed
colin-axner opened this issue Mar 17, 2023 · 3 comments
Closed

Improperly formatted proto file causes ORDER_BY_DESC enum to be parsed incorrectly #15437

colin-axner opened this issue Mar 17, 2023 · 3 comments
Labels
T: Tests

Comments

@colin-axner
Copy link
Contributor

Summary of Bug

There's an extra semi-colon in the proto file on the release/v0.46.x line (fixed on main/v0.47)

Version

release/v0.46.x

Steps to Reproduce

Using stake.tax you can use any chain on the v0.46.x release line, use the cli to generate csv and you'll run into the error: strconv.ParseInt: parsing "ORDER_BY_DESC": invalid syntax'. This can be fixed on stake.tax by using 2 instead of ORDER_BY_DESC. I believe removing the extra semi-colon will allow the enum to be properly parsed again

Please add a test for this workflow since dependencies use this functionality
@github-actions github-actions bot added the needs-triage Issue that needs to be triaged label Mar 17, 2023
@colin-axner colin-axner added T:Bug and removed needs-triage Issue that needs to be triaged labels Mar 17, 2023
@colin-axner colin-axner mentioned this issue Mar 17, 2023
Closed
@julienrbrt julienrbrt mentioned this issue Mar 17, 2023
Merged
19 tasks
@julienrbrt
Copy link
Member

What kind of test are you thinking about?

@colin-axner
Copy link
Contributor Author

What kind of test are you thinking about?

A test that uses the order_by argument in the URL request? Would that be possible?

@julienrbrt julienrbrt added T: Tests and removed T:Bug labels May 9, 2023
@github-project-automation github-project-automation bot moved this to 📝 Todo in Cosmos-SDK Aug 18, 2023
@tac0turtle tac0turtle moved this to To Do in Cosmos-SDK Oct 6, 2023
@julienrbrt
Copy link
Member

This should catch it next time: https://github.com/cosmos/cosmos-sdk/blob/v0.52.0-beta.1/.github/workflows/proto.yml#L13-L22

@julienrbrt julienrbrt closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
@github-project-automation github-project-automation bot moved this from 📋 Backlog to 🥳 Done in Cosmos-SDK Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: Tests
Projects
Cosmos-SDK
Status: 🥳 Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tac0turtle @colin-axner @julienrbrt